fix: Allow filtering null values #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user expressed interest in filtering with a null value. This typescript parameter change will now allow users to do so. fixes googleapis#958
product-auto-label
bot
added
size: s
The code in the system test folder reflects the user experience more closely so we want to provide test cases there that will break when compiling typescript if new changes in src are not provided.
kolea2
reviewed
Feb 16, 2023
danieljbruce
changed the title
ruyadorno
reviewed
Feb 16, 2023
Add assert statements to check that the value in the filter created in the system test actually equals null.
Slight rename in system tests. Modified tests so that they test to see that the filter has a null value.
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
This change replaces the a longer fragment with elvis operator to make assert statements more concise.
In two tests we eliminate variables and just have an assert statement so that we can have more concise code.
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user expressed interest in filtering with a null value. Currently this is possible if a null value is provided in a variable, but if a
nullliteral is passed intovaluefor.filterthen we get a typescript compiler error. This typescript parameter change will now allow users to not experience the typescript compiler error when trying to filter by null.Fixes #958